jeromelachaud / freelancer-theme

Jekyll theme based on Freelancer Start Bootstrap theme
https://jeromelachaud.com/freelancer-theme
MIT License
1.45k stars 2.3k forks source link

Remove root-relative references that break the theme (should fix #114) #143

Closed Avonnaire closed 2 years ago

Avonnaire commented 2 years ago

GitHub Pages is currently attempting to load CSS and JS from the root site, i.e yourusername.github.io, and as such it breaks. I removed the root-relative references, and it should work on every site now.

I hadn't checked for issues when I did this, and later found out about #114. This should help close the issue, I tested it on my own deployment (https://avonnaire.github.io/freelancer-theme/) and it seems to work. On the issue there is another solution described which I have not tried, if you feel the way I currently implemented it is not as Jekyll-esque as it should be, I'll try that next. Nothing should break with the current change, though.

jeromelachaud commented 2 years ago

merged 👍