search

jeromeludmann / deno-irc

IRC client protocol module for Deno
https://deno.land/x/irc
MIT License
13 stars 4 forks source link

chore(ci): run CI only on main #8

Closed jeromeludmann closed 1 year ago

jeromeludmann commented 1 year ago

Runs Github actions only when a pull request is open or when commits are pushed to main.

xyzshantaram commented 1 year ago

So far, so good. Do you think it also makes sense to only run CI when the PR is onto main? I don't know if we'll ever be in a situation where we will be PR-ing between branches on the same repo but it could be nice to have.

Also, while we're on the subject of CI, we could create a workflow to automatically make a release whenever we push to a certain branch. We'd have to figure out a way to specify the version number though.

jeromeludmann commented 1 year ago

So far, so good. Do you think it also makes sense to only run CI when the PR is onto main? I don't know if we'll ever be in a situation where we will be PR-ing between branches on the same repo but it could be nice to have.

I agree it makes sense to run CI on each pull request 👍 I just made a change.

Also, while we're on the subject of CI, we could create a workflow to automatically make a release whenever we push to a certain branch. We'd have to figure out a way to specify the version number though.

It would be great! (but personally for now don't have time to do this)

The version number could be generated if we are strict about commit (for instance a fix commit bumps patch version whereas a feat commit bumps minor version) and maybe we could also generate the release changelog.

xyzshantaram commented 1 year ago

It would be great! (but personally for now don't have time to do this)

Would you mind if I wrote a draft of the functionality for you to look at?

The version number could be generated if we are strict about commit (for instance a fix commit bumps patch version whereas a feat commit bumps minor version)

I'll have to get better about my commit message discipline, but that's a smart way to do it!

and maybe we could also generate the release changelog.

Mhm, it could just be a list of the commits at bare minimum.

jeromeludmann commented 1 year ago

It would be great! (but personally for now don't have time to do this)

Would you mind if I wrote a draft of the functionality for you to look at?

Good idea, although for me it's not a real problem to bump the tag manually, I will be happy to see an automation for that.

xyzshantaram commented 1 year ago

Hi, I just had an idea for automating releases. What if we made it so releasing was done by making a commit onto main with the title vX.Y.Z?

The changelog would be the commit message unless the commit said "@generate_changelog" and in that case the action could autogenerate the changelog.

jeromeludmann commented 1 year ago

Could be nice. Currently it's the addition of a new tag on a commit on main that makes a release on deno.land/x but maybe adding a specific commit to automate it would be better.

Honestly I don't know which is the best practice for that 🤔