search

jeromepl / highlighter

A Chrome extension to highlight text and keep it all saved
MIT License
308 stars 77 forks source link

[Feature Request] Highlight colors for dark mode #20

Closed OLucasZanella closed 2 years ago

OLucasZanella commented 3 years ago

This extension is precisely what I was looking for, except for one caveat: I'm always using the Dark Reader extension, which makes all web pages dark.

Since the text becomes white, highlighting it with the light colors available renders it almost impossible to read. Would it be possible to add some options for white text as well? One single custom color option would also do the trick.

sfd99 commented 3 years ago

I totally agree with OLucasZanella, (request above).

I use DARK MODE in Chrome, for limited eyesight and the text in highlighted items are extremely hard to read, (they appear as unreadable gray text).

An Option to change the color of the TEXT inside a highlight , ie: white to black text and vice-versa, would be VERY HELPFUL to many of us.

Please Jerome, do it. Thank you / Merci!.

SFd99 San Francisco. latest Chrome Ubuntu Linux 20.04

jeromepl commented 2 years ago

I have added a feature to customize highlight colors and the text color in the highlights. This should resolve the issue with dark mode! Expect this to be released in v4 in early January 🙂

OLucasZanella commented 2 years ago

Awesome, I'm sure it will be useful!

Unfortunately, I'm using Firefox at the moment, but if I ever get back to Chrome, I'll be using this extension again, it's great.