search

jeromepl / highlighter

A Chrome extension to highlight text and keep it all saved
MIT License
315 stars 80 forks source link

Multiple highlights pasted like a single paragraph #22

Closed ujeshkrishnan closed 2 years ago

ujeshkrishnan commented 3 years ago

I used to mark multiple sentences from a single blog post.

Then I hit "Copy all" button in the extension and pasted in my notes.

What happened is that, the whole texts pasted like a single paragraph instead of multiple short paragraphs.

This is causing additional manual work to separate the highlighted lines.

I hope you'll fix it soon.

jeromepl commented 3 years ago

Hi @ujeshkrishnan , could you provide a bit more info about this issue you are facing? When I use the "Copy all" button on a page where I have multiple highlights, the result of pasting is a bullet list of all the highlights. For example in microsoft word: image

ujeshkrishnan commented 3 years ago

I tried pasting on Standard Notes & Google Docs but couldn't see it appear as bullet points.

Browser: Brave Device: MacBook Air

neognomic commented 3 years ago

I have a related issue(#27) with Opera (currently 80.0.4170.40) that causes the same thing to happen. If I select copy from the popup widget for a single highlighted section Highlighter copies all the highlighted text on the entire page and pastes as one paragraph. E.g., This is using the copy one section of 3 sections that are highlighted: “We fundamentally need it to meet our climate goals. That’s just the reality. And now we can’t. So this is pretty sad.”For weeks, Democratic leaders have vowed that the clean electricity program was a nonnegotiable part of the legislation. Progressive Democrats held rallies chanting “No climate, no deal!”It is also possible that Democrats may try to push through the clean electricity program as a stand-alone bill — but the timeline for doing so is narrowing, with the 2022 midterm elections approaching.

This is using the Copy All: “We fundamentally need it to meet our climate goals. That’s just the reality. And now we can’t. So this is pretty sad.”For weeks, Democratic leaders have vowed that the clean electricity program was a nonnegotiable part of the legislation. Progressive Democrats held rallies chanting “No climate, no deal!”It is also possible that Democrats may try to push through the clean electricity program as a stand-alone bill — but the timeline for doing so is narrowing, with the 2022 midterm elections approaching.

( RE: https://www.nytimes.com/2021/10/15/climate/biden-clean-energy-manchin.html )

As you can see, no bullets and 'run-on' copy.

I just tested it with Edge 94.0.992.50 browser, and Copy All separates the paragraphs but has no bullets. The individual copy works also(as does highlighting).

jeromepl commented 2 years ago

I just pushed a change to the way the "Copy All" button works. In short, we now use navigator.clipboard.writeText instead of document.execCommand("copy")

I'm hoping this will fix the issue for both of you as this is not copy-pasting the HTML structure of the highlights in the popup anymore, but rather is simply copy-pasting the text, where each highlight is separated by a new line. In most text editors, if already within a bullet point list, this will result in one new bullet point per highlight

I will be releasing this as part of v4 in early January :)