search

jeromepl / highlighter

A Chrome extension to highlight text and keep it all saved
MIT License
315 stars 80 forks source link

Toggle cursor doesn't work #45

Closed neooleg closed 2 years ago

neooleg commented 2 years ago

STR

  1. Use Chrome Version 107.0.5304.62 (also tested on 106.0.5249.119)
  2. Select any text on a webpage e.g. wikipedia.org
  3. Open highlighter's popup and click the Toggle cursor button

AR

Nothing happens

ER

According to https://github.com/jeromepl/highlighter/blob/master/src/contentScripts/highlighterCursor/index.js it seems the highlight mode should be enabled w/ cursor changed, but cursor doesn't change

Investigation notes

Probably cursor.png is absent in assets and that might be a reason of non working feature https://tppr.me/sZFJr

jeromepl commented 2 years ago

Thanks for the bug report, I identified the source of the problem and pushed a fix. I will submit a new release of the extension to the chrome web store soon, probably under version number 4.0.3

neooleg commented 2 years ago

Jérôme, thank you for such a quick turnaround with the fix 🙌

On Sun, 30 Oct 2022 at 16:17, Jérôme Parent-Lévesque < @.***> wrote:

Thanks for the bug report, I identified the source of the problem and pushed a fix. I will submit a new release of the extension to the chrome web store soon, probably under version number 4.0.3

— Reply to this email directly, view it on GitHub https://github.com/jeromepl/highlighter/issues/45#issuecomment-1296270982, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMSDSJDTGLZ4SM5RTSWK5TWFZ7QHANCNFSM6AAAAAARQIJXUQ . You are receiving this because you authored the thread.Message ID: @.***>

--

Best regards,

Oleg V.