search

jeromerobert / hmat-oss

A hierarchical matrix C/C++ library
GNU General Public License v2.0
22 stars 11 forks source link

gcc 7 support #52

Closed jschueller closed 7 years ago

jschueller commented 7 years ago

Compilation fails with Werror enabled (default) as there are many warnings:

src/full_matrix.hpp:281:81: warning: invalid use of incomplete type ‘const class hmat::IndexSet’
     convert << "FullMatrix " << this->rows_->description() << "x" << this->cols_->description() ;

src/postscript.cpp:241:13: warning: declaration of ‘startY’ shadows a previous local [-Wshadow]
         int startY = m->rows()->offset();

src/h_matrix.cpp:1471:6: warning: declaration of ‘depth’ shadows a member of ‘hmat::HMatrix<std::complex<double> >’ [-Wshadow]
 void HMatrix<T>::dumpSubTree(ofstream& f, int depth, const HMatrixNodeDumper<T>& nodeDumper) const {

...
jeromerobert commented 7 years ago

@jschueller I do not understand why you have -Wshadow enabled. From the gcc manual it's not in -Wextra. Did you add it to manually ?

jschueller commented 7 years ago

I did not set CFGLAGS or CXXFLAGS in the env, just ran 'cmake ..'. If I remove Werror from CmakeLists it goes away.

jschueller commented 7 years ago

it seems to go away with a clean vm, should be on my side, sorry for the noise