search

jeromerobert / hmat-oss

A hierarchical matrix C/C++ library
GNU General Public License v2.0
22 stars 11 forks source link

Fix undeclared openblas_set_num_threads #63

Closed jschueller closed 5 years ago

jschueller commented 5 years ago

Check that openblas_set_num_threads is declared, otherwise build will fail using lapack's cblas.h header.

dbarbier commented 5 years ago

Hi @jschueller, a mismatch between headers and libraries is a user error; it is better to let build fail instead of hiding this error.

jschueller commented 5 years ago

ok, fine with me thanks

dbarbier commented 5 years ago

@jschueller BTW the only reason why goto_get_num_procs is defined in disable_threading.cpp is because earlier versions of openblas did not define it in cblas.h; when we drop support for openblas < 0.2.14, we will remove it.