Operator precedence and initialization error raised when compiled with g++-12

[pgrt]

Hello,

I am the Debian maintainer for hmat-oss. It appeared that hmat-oss fails to build with g++-12, because of two errors that were raised (see complete log at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012945#5):

• The precedence of + is higher than the one of ?: so that, in src/zk_matrix.cpp, you are currently comparing b2->memorySize() + a1 with NULL on lines 991 and 992 ;
• There is an initialization error because of an array of which initialization is conditional.

I propose the attached patch, that solves the issues. Could you please review to tell me if the first fix is correct? I tried to understand the meaning of the piece of code from the context.

Best regards, Pierre

initialization_and_parentheses_issues.txt

[dbarbier]

Hi @pgrt these build failures had already been fixed in master, see commits eedeebd and 899d4e0.

[pgrt]

Hi @dbarbier Thanks for your comment and sorry for the noise, I was looking at the last tagged version and thus missed these commits.

Cheers, Pierre