search

jerone / UserScripts

🐵 My UserScripts
https://github.com/jerone/UserScripts#readme
GNU General Public License v3.0
339 stars 39 forks source link

Adds support for byond .dmi files to the github image viewer. #46

Closed Boggart closed 9 years ago

Boggart commented 9 years ago

Adds previewing support for byond .dmi files. (They're really just PNGs with some metadata.)

jerone commented 9 years ago

Do you have a test case I can test...

jerone commented 9 years ago

Something like: https://github.com/DuncanFairley/Dungeon-Master/blob/master/icon.dmi ???

If that's the case I'm not going to merge this PR, because you probably have a plugin running that can open that file in your browser, while out-of-the-box this isn't supported for everyone else. Sorry.

If GitHub doesn't support viewing it, I probably won't support it too.

Boggart commented 9 years ago

I'd thought that github supported viewing them natively but it seems I was wrong, that was an image hosting site that apparently sent the data as a regular png despite the extension.

Previewing the files on hover does work, but if you click on them github doesn't serve it as an image. https://github.com/tgstation/-tg-station/tree/master/icons

I'll close this for now and re-open it if github gets support for dmi files in the future.

jerone commented 9 years ago

You could contact GitHub and ask for .dmi file support. They mostly respond quickly.

Still thanks for using.

Boggart commented 9 years ago

I've contacted them about supporting it, thank you for writing these useful userscripts.