(Github News Feed Filter) all entries counters are zero

[darkred]

Today I noticed that entries counters (and sub-counters) are all zero: Filtering still works ok.

This is what I get this in Browser Console when opening https://github.com/ :

alert.querySelector(...) is null             Github_News_Feed_Filter.user.js:210:8

Using FF40(tested in a clean profile too) with GM 3.3 and script v5.3.

[jerone]

Hmm, just tested and can't confirm with same specs. The script works for me just as intended. Do you have any other userscripts running?

[darkred]

No, as I've written, it also occurs in a clean FF40 stable profile, with only GM 3.3 and the script installed. Also, my news feed has entries.

And in order to confirm that we use the same Firefox version: the changeset of my Firefox 40 stable (windows) is https://hg.mozilla.org/releases/mozilla-release/rev/84e0a4087157 (found in about:buildconfig).

[jerone]

And in order to confirm that we use the same Firefox version: the changeset of my Firefox 40 stable (windows) is https://hg.mozilla.org/releases/mozilla-release/rev/84e0a4087157

Yeah same.

What I did noticed was that the "More" button doesn't recount the filters. But that still gives me 30 on all news feed.

I also notice that there are small changes to GitHub done today. Maybe they are in the progress of more changes.

[jerone]

What is the first item in your news feed? Maybe the first item is a new filter item that isn't supported yet...

[darkred]

The first item is this last comment of yours on this issue:

Also, all other entries are all supported (they are actions on issues and pull requests).

[jerone]

Can you do a HTML dump of all items with the octicon-git-pull-request icon. I'm still leaning to a news item that I've never seen before.

[darkred]

If I got it right, you want me to document.getElementsByClassName("octicon-git-pull-request") (without the script running) which results as

HTMLCollection [ 
<span.mega-octicon.octicon-git-pull-request>, 
<span.mega-octicon.octicon-git-pull-request>, 
<span.mega-octicon.octicon-git-pull-request> ]

and then click on each of these 3 elements and copy outer HTML of each entry. If this so, then it's this here: http://pastebin.com/vx4CTxTB

Also, all entries I have in news feed (apart from https://github.com/jerone/UserScripts/ ) are from https://github.com/greasemonkey/greasemonkey/

[jerone]

So yeah, they changed something for PR news items. I don't have any PR items in my news list right now, but I'll try to find a fix for it. Thanks for helping finding the issue :purple_heart:

[darkred]

Glad to be of help.

[darkred]

Greetings, @jerone 🙂

Unfortunately the issue has occurred again: all counters (in all three tabs of the script table, i.e. Actions/Repositories/Users) are zero.

There's no error in Console.

Using script v8.2.5 with Tampermonkey 4.8.5867 in Chrome 70. Tested it with only TM running.

Here is a screenshot of my news feed:

Screenshot


[jerone]

I can confirm it, and they changed the HTML again. It looks like every ':scope > div > .body' needs to be changed to `':scope > div > div > .body'. I'll try to find to time to make a fix soon (but a PR is always great).

[darkred]

Your suggestion fixes the issue. Thank you! 👍

Here is the PR: https://github.com/jerone/UserScripts/pull/140