jerone / UserScripts

🐵 My UserScripts
https://github.com/jerone/UserScripts#readme
GNU General Public License v3.0
339 stars 39 forks source link

Fixed issues after Github site update #69

Closed jerone closed 9 years ago

jerone commented 9 years ago

Fixes https://github.com/jerone/UserScripts/issues/68

jerone commented 9 years ago

@darkred This PR contains a fix for your issue and other changes to GitHub new changes. I was hoping you could give this version a try to confirm that the fix works.

darkred commented 9 years ago

Yes, it's working ok now. Just one thing: the filters now appears in a table which has borders (which makes the table rather confusing -- too many horizontal borders ): screenshot I'd definitely prefer the previous version where there were no borders at all.

Or alternatively, I'd suggest no borders -or dotted borders, i.e. more subtle ones- between rows of subcategories that belong to the same category. But keep the new maincategory+subcategories highlighting (when clicking a main category). Here is a mockup for my suggestion: http://i.imgur.com/5NPm3Iz.jpg

jerone commented 9 years ago

Yes, it's working ok now.

Yeah thanks for testing :+1:

Just one thing: [...]

I removed the previous theme because of GitHub removing it from every elements and switching to the current theme. Personally I prefer the new one, but I just want to precede GitHub when they remove the theme all together with all these updates to the GitHub site.

Just did a commit testing a design with arrows... 2015-08-12 23_26_53-github

Not sure yet about the best solution... will try your suggestion soon.

jerone commented 9 years ago

Reminder for myself;

darkred commented 9 years ago

Yeah thanks for testing

You're welcome.

Not sure yet about the best solution... will try your suggestion soon.

Great! :+1:

jerone commented 9 years ago

So I kind of settled on a combination of your and mine style suggestions: 2015-08-15 22_41_56-github Besides the yellowish background color, font is now bold. I used dashed borders for sub filters, but kept the indention and arrows, because there are also sub sub filters.

darkred commented 9 years ago

It's great now. Thank you.

jerone commented 9 years ago

@darkred Just merged this PR. Thanks for mentioning the issue, helping with debugging and testing. Mirrors should be synced very soon.