jerone / UserScripts

🐵 My UserScripts
https://github.com/jerone/UserScripts#readme
GNU General Public License v3.0
342 stars 39 forks source link

Github Comment Enhancer breaks Github's name completion #81

Closed thomaslevesque closed 9 years ago

thomaslevesque commented 9 years ago

When you type "@", Github displays a list of suggestions to mention other people. When GCE is enabled, I can no longer pick a choice from this list with the keyboard, I have to use the mouse.

jerone commented 9 years ago

Thanks for reporting. I've noticed it too, never thought to link it to Github Comment Enhancer. Confirmed and same goes for emoji.

jerone commented 9 years ago

Wow, that was a hard one to fix. Hopefully tracked the cause down.

@thomaslevesque Any change you could test if the fix solves the problem for you too: https://github.com/jerone/UserScripts/blob/Github_Comment_Enhancer/Github_Comment_Enhancer/Github_Comment_Enhancer.user.js (click Raw to install dev version).

thomaslevesque commented 9 years ago

@jerone, it works :)

Well done and thanks ! This bug was really annoying ;)

jerone commented 9 years ago

I'm working on another fix for using the keyboard on the toolbar dropdown buttons too. After that I'll release a new version of Github Comment Enhancer, so you can switch back to the live version.

thomaslevesque commented 9 years ago

OK, thanks!

jerone commented 9 years ago

Fixed and :ship:ed