The "italic" button no longer works (but ctrl+i still works ok)

jerone / UserScripts

🐵 My UserScripts

https://github.com/jerone/UserScripts#readme

GNU General Public License v3.0

339 stars 39 forks source link

The "italic" button no longer works (but ctrl+i still works ok) #83

Closed darkred closed 8 years ago

darkred commented 8 years ago

After the latest update to v2.7.0 (in GM 2.6 in FF42) I noticed that, clicking the italic button (having selected text or not, it doesn't matter) doesn't work (but ctrl+i still works ok).

This is what I get in Browser Console: TypeError: definitionObject is undefined Github_Comment_Enhancer.user.js:416:1

Thank you

jerone commented 8 years ago

Confirmed, will have a look.

jerone commented 8 years ago

Was a missed refactor in https://github.com/jerone/UserScripts/commit/9bf8974ad4203d7c2361a645405491c9903a9238, but this opened up a bigger issue where the wiki won't work anymore.

Going to revert most of that commit.

jerone commented 8 years ago

A fix for this :bug: and more has been :ship:ed.

Thanks for reporting!

darkred commented 8 years ago

You're welcome! Thank you