search

jerone / UserScripts

🐵 My UserScripts
https://github.com/jerone/UserScripts#readme
GNU General Public License v3.0
342 stars 39 forks source link

(Github Comment Enhancer) Clicking on the smiley button takes quite long #87

Closed rugk closed 8 years ago

rugk commented 8 years ago

smileyclick

jerone commented 8 years ago

Confirmed. It's kind of intentional, the whole list is AJAX fetched and then attached to the DOM. To not overload GitHub and block the page every time this userscript is loaded, the whole list is only loaded on emoji button click and the cached until page refresh.

rugk commented 8 years ago

Okay, I see (this also in the developer console). So what about:

  1. at first only displaying the text and later loading the images
  2. only load the images of the smilies currently displayed (as you really seem to load all smileys, you may rather try to load only the images which are shown)
jerone commented 8 years ago

I'll have a second look if I can improve loading time of the emoji dropdown.

jerone commented 8 years ago

Closing in favor of https://github.com/jerone/UserScripts/issues/106