search

jerone / UserScripts

🐵 My UserScripts
https://github.com/jerone/UserScripts#readme
GNU General Public License v3.0
342 stars 39 forks source link

(Github Comment Enhancer) When the smiley buttons clicked you cannot drag & drop files to upload them #88

Closed rugk closed 8 years ago

rugk commented 8 years ago

Actually you can, but is the wrong input field... :laughing: clickdraganddrop

jerone commented 8 years ago

Why do you want to drag and drop to upload? Just clicking the emoji will insert the correct emoji code tag that GFM will convert into an image.

EDIT: Oh sorry, I get it now. Drag and dropping a file isn't supported anymore when menu's are open.

rugk commented 8 years ago

It is supported - but in the wrong input field. :wink:

jerone commented 8 years ago

Aldo I recognize the issue, I'm not going to try fix this for two reasons. 1. This is a bug from GitHub as the same happens when opening any dropdown menu. 2. Closing is just one click or key away. Thanks for reporting!

rugk commented 8 years ago
  1. This is a bug from GitHub as the same happens when opening any dropdown menu

Okay, but as they do not have dropdown menus by default on their comment part you cannot really blame them...

jerone commented 8 years ago

@rugk commented on 9 dec. 2015 18:31 CET:

  1. This is a bug from GitHub as the same happens when opening any dropdown menu

Okay, but as they do not have dropdown menus by default on their comment part you cannot really blame them...

The kind of do. When admin of a repo, the labels, milestones and assignee all overlap the comment field, but more importantly they create some kind of overlay preventing dropping a file besides the menu.

rugk commented 8 years ago

When admin of a repo, the labels, milestones and assignee all overlap the comment field

Ah did not thought of these dropdowns... :smile: They are much more far away from the comment field than the dropdown by this script. :smiley:

but more importantly they create some kind of overlay preventing dropping a file besides the menu.

Okay, yes this an issue. Have you already reported this to GitHub?

jerone commented 8 years ago

Have you already reported this to GitHub?

No. You are free to do so :)

rugk commented 8 years ago

Done.

And just discovered https://github.com/jerone/UserScripts/issues/91... :smile:

rugk commented 8 years ago

Reply from GitHub support:

Thanks for the report! I'm seeing the same thing - we can't promise if or when the behavior might change, but we'll mention this to our front end folks for investigation.