search

jerrellmardis / Amphitheatre

Amphitheatre is an Android TV app that connects with network shares, organizes and serves videos to any Android capable media player app.
Apache License 2.0
437 stars 87 forks source link

Switch from TMDb to TheTVDB for TV show information fetching #31

Closed jerrellmardis closed 9 years ago

jerrellmardis commented 10 years ago

The TheTVDB has a wider range of available shows so we should probably use that instead.

MizzleDK commented 10 years ago

You might want to leave it as an option. TMDb's TV database is getting a lot better and it supports high resolution episode photos, which TheTVDb doesn't.

eyedol commented 10 years ago

Perhaps, a settings to allow users to switch which service( TMDb vs TheTVDB ) to fetch shows from? Stating the pros and cons with each service?

MizzleDK commented 10 years ago

Yeah, it should be fairly simple to do. Just create a "service" interface, which includes the basics (search, TV show retrieval, etc.) and create a class for each service that implements the interface and has its own code to search and such.

eyedol commented 10 years ago

Exactly my thinking. Way to go.

JakeWharton commented 10 years ago

Settings are terrible! How do I know which I should be using? The app should do the right thing without the user having to make a decision on something for which they have zero context on. On Aug 13, 2014 3:40 AM, "Henry Addo" notifications@github.com wrote:

Exactly my thinking. Way to go.

— Reply to this email directly or view it on GitHub https://github.com/jerrellmardis/Amphitheatre/issues/31#issuecomment-52033089 .

MizzleDK commented 10 years ago

In this case there's no such thing as "the right thing". None of them are perfect.

TheTVDb's API is seriously outdated compared to TMDb. TMDb offers more information about TV shows and higher resolution images. On the other hand, the content on TheTVDb gets updated slightly faster due to a larger user group, which might appeal to some users.

JakeWharton commented 10 years ago

So we use both. One for images and overview and the other for per-episode data.

On Wed, Aug 13, 2014 at 8:33 AM, Michell Bak notifications@github.com wrote:

In this case there's no such thing as "the right thing". TheTVDb's API is seriously outdated and TMDb offers more information about TV shows and higher resolution images. On the other hand, the content on TheTVDb gets updated slightly faster, which might appeal to some users.

— Reply to this email directly or view it on GitHub https://github.com/jerrellmardis/Amphitheatre/issues/31#issuecomment-52065179 .

eyedol commented 10 years ago

So they both fallback on each other... Makes sense