search

jerremyng / pe

0 stars 0 forks source link

Edit command shows success even when details not changed #3

Open jerremyng opened 4 months ago

jerremyng commented 4 months ago

Information

When editing a person and not changing any details, the success message is still thrown.

Steps to reproduce

Enter the commands. This assumes contacts list is empty.

  1. add n/Taylor Shesh p/98765432 e/taytay@taylor.com a/Rhode Island
  2. edit 1 n/Taylor Shesh

Expected

A message saying that no fields changed.

Actual

Success message was given, and it is indistinguishable from an actual edit.

Screenshot 2024-04-19 at 4.40.58 PM.png

soc-se-bot commented 4 months ago

Team's Response

We have actually stated in our UG: "Editing a contact with the same value will still be considered a successful edit, and LookMeUp will prompt a "successful" message."

Furthermore, the act of editing still happened regardless of whether the edited field has the same content as the original or a different one.

image.png

As per the course guidelines, we deem this as NotInScope

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thanks for your response, however I think you may have mislabeled this by accident. After reading your response, I do agree that this issue sounds like a response.NotInScope.