jerremyng / pe

0 stars 0 forks source link

Wrong response when using an invalid overwrite command #5

Open jerremyng opened 4 months ago

jerremyng commented 4 months ago

Information

After some testing, I found out that the overwrite command is supposed to have an index contrary to what error message says. Therefore trying to use the overwrite command without an index should lead to a invalid error message.

Steps to reproduce

  1. add n/Taylor Sheesh p/98765432 e/taytay@taylor.com a/Rhode Island
  2. overwrite n/Taylor Sheesh p/9999 e/sheeshee@com a/island

Expected

A message saying invalid command format, such as the one shown below when overwrite is entered. Screenshot 2024-04-19 at 4.55.41 PM.png

Actual

The app responds with new person added, even though I used the wrong command format without an 'index' Screenshot 2024-04-19 at 4.56.40 PM.png

nus-pe-script commented 4 months ago

Team's Response

No details provided by team.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Since no details/responses were provided, I am still unclear as to why this was rejected.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This looks to me like incorrect behaviour of the `overwrite` command, therefore a `type.FunctionalityBug`