Overwrite command shows success even when person not overwritten

[jerremyng]

Information

When overwriting a person and not changing any details, the success message is still thrown.

Steps to reproduce

Enter the commands. This assumes contacts list is empty.

1. add n/Taylor Shesh p/98765432 e/taytay@taylor.com a/Rhode Island
2. overwrite 1 n/Taylor Shesh p/98765432 e/taytay@taylor.com a/Rhode Island

Expected

A message saying that no fields changed.

Actual

Success message was given even though nothing changed, and it is indistinguishable from an actual overwrite.

[soc-se-bot]

Team's Response

Hi, thanks for highlighting this. In our interpretation and implementation of this command, we took it that an overwrite command will be successful, as long as the command format is deemed to be correct.

As long as content that fits each of the fields correctly (eg. name, phone number, email address etc..) is being input in the overwrite command, we take it as a general success.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: After reviewing your response, I think this issue would warrant a response.IssueNotInScope. Thanks for sharing how your thought process behind the implementation, but from the user's perspective, the average user would interpret existing person overwritten to mean that something has changed. This feels like something that should be improved on in versions, therefore the response.IssueNotInScope.

---

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]

---