jerremyng / pe

0 stars 0 forks source link

Clear command is less safe than remove command #7

Open jerremyng opened 4 months ago

jerremyng commented 4 months ago

Information

The remove command is safe, meaning that it requires confirmation from the user before removing a person. However, the clear command does not require confirmation, even though it is potentially more dangerous than removing a single person.

Steps to reproduce

To an empty contact list, enter

  1. add n/Taylor Sheesh p/98765432 e/taytay@taylor.com a/Rhode Island
  2. remove 1 (note how there is a confirmation screen)
  3. clear (My contacts are deleted instantly)

Expected

Since remove has a confirmation section, it is natural to assume that clear would have the same safety features. This assumption can lead to users accidently deleting their all contacts.

Actual

Screenshot 2024-04-19 at 5.10.13 PM.png

soc-se-bot commented 4 months ago

Team's Response

Thank you for your testing!

After assessing the usage frequency of commands, the team designed this feature with user behavior in mind. Given that removing contacts individually is more common among our users, we opted to implement an additional layer of protection and confirmation specifically for the frequently used "remove" command.

Additionally, it will be challenging to pin-point which contact has been removed from a sizeable contact list (if the user has ~100 contacts) as compared to clear where user can easily see that the entire contacts in the contact list have been removed. In the latter case, our team also did not turn a blind eye. We added an 'undo' command where user can easily run the command and undo the apparent mistake that they have done.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]