jerrod-lankford / google-voice-desktop-app

An electron shell wrapper around the google voice website

248 stars 38 forks source link

Clicking voice icon does not open voice. #10

Closed brmonaghan closed 3 years ago

brmonaghan commented 3 years ago

Sorry for being a problem @Jerrkawz and @joshnovak ! I have one more thing that does NOT work, the voice icon in the taskbar. It does not open upon clicking it. I want this to open voice when clicking this. @joshnovak can you attempt to fix this and PR this to the main form? or can this be fixed by you, @Jerrkawz ? Thanks

jerrod-lankford commented 3 years ago

He coded it up as double clicking will open, so technically its working as designed but i think I agree, id like it to open on a single click. Also double clicking doesn't work on mac osx either. Whoever has time can fix this, it should be as simple as changing line 147 from 'double-click' to click, but needs to be tested on mac and windows.

brmonaghan commented 3 years ago

Ok, thank you!

brmonaghan commented 3 years ago

@Jerrkawz I will write the single line on my fork of the project, and then make a PR to your project. You can tag along @joshnovak

brmonaghan commented 3 years ago

build done. now testing

brmonaghan commented 3 years ago

Works. Also changed refresh rate for new messages to 1 sec instead of 5

brmonaghan commented 3 years ago

sending pr right now for you to review.

brmonaghan commented 3 years ago

12 now available for you to review @Jerrkawz

brmonaghan commented 3 years ago

If this is okay, We can close it.

brmonaghan commented 3 years ago

Closing as this is fixed in my build of gv desktop. More info on my fork of gv desktop here