In this commit we update the application so that Windows Toasts that get generated always contain the application name and icon. To do this, we tweak the application's existing notificationShim module. Whenever a notification is generated that doesn't have an icon, we set the icon to be the application icon.
During application startup, we also make a call to app.setAppUserModelId(), setting our application name. This ensures that "Google Voice" shows up as the sender of the Toast instead of "electron.app.Electron", which is what shows up today.
In this change we also introduce a new constants module for sharing application constants between files.
We also update the notification area icon's tooltip text so that it matches the application name.
Testing
Tested on Windows.
Tested Toast generated due to incoming text message.
Tested Toast generated due to incoming phone call.
Changes
In this commit we update the application so that Windows Toasts that get generated always contain the application name and icon. To do this, we tweak the application's existing
notificationShim
module. Whenever a notification is generated that doesn't have an icon, we set the icon to be the application icon.During application startup, we also make a call to
app.setAppUserModelId()
, setting our application name. This ensures that "Google Voice" shows up as the sender of the Toast instead of "electron.app.Electron", which is what shows up today.constants
module for sharing application constants between files.Testing