jerrod-lankford / google-voice-desktop-app

An electron shell wrapper around the google voice website
246 stars 37 forks source link

Display Application Name and Icon in Toasts #83

Closed eFail closed 2 years ago

eFail commented 2 years ago

Changes

In this commit we update the application so that Windows Toasts that get generated always contain the application name and icon. To do this, we tweak the application's existing notificationShim module. Whenever a notification is generated that doesn't have an icon, we set the icon to be the application icon.

During application startup, we also make a call to app.setAppUserModelId(), setting our application name. This ensures that "Google Voice" shows up as the sender of the Toast instead of "electron.app.Electron", which is what shows up today.

image

Testing