Add standard keyboard shortcuts for zoom (Ctrl++, Ctrl+_).
Add ability to go full screen (F11).
Remove injected "Customize" button, replace with new "Settings" menu item.
Settings Window changes:
Set title of window.
Removed dependency on "@electron/remote" module; switched to direct IPC.
Removed BrowserView use to fix issue where window opens blank sometimes.
Make window modal.
Prevent window from being opened more than once at a time.
Add slider control for "Zoom" setting.
Add "Show menu bar" setting.
Add "Exit application when main window is closed" setting.
Allow Escape key to close window.
Made setting labels bold for readability.
Remarks
Removal of Injected "Customize" Button
Since many users have reported various scenarios in which the "Customize" button (that gets injected into Google Voice's markup on load) goes missing, we have stripped the button out entirely. It has been replaced by a new Settings item found in the main window's Menu Bar and notification area icon context menu.
Zoom Shortcuts / Menu Bar
In this change we do some work to support the standard keyboard shortcuts for zooming in and out that people are used to in the browser. That is, the ability to press Ctrl+= or Ctrl++ to zoom in, to press Ctrl+- or Ctrl+-_ to zoom out, and to press Ctrl+0 to reset the zoom level. The key to implementing this was to add a Menu Bar to the main application window, placing inside it the standard role zoom items that come built in to Electron. Since a Menu Bar was necessary for zoom, I took it a step further and implemented menu items for all the primary functionality in the application. F11 is now supported as well, which allows you to go full screen.
For those that don't want a Menu Bar, there is a new option in the Settings window for turning it off. But all zoom shortcuts will continue to work even when the Menu Bar is turned off, because rather than actually remove it, we just hide it :).
Zoom Slider
In the Settings window, there's a new Slider control hooked up to the zoom functionality of the main window. Whereas we used to modify the zoom factor to zoom in/out, we now modify the zoom level, and we allow the exact same minimum and maximum values that the browser does (which is what Electron's built in zoom menu items allow). That is, we allow a zoom range of 25% to 500% to be selected. Additionally, we take advantage of the fact that Electron remembers the last applied zoom level (the way the browser does), so we no longer need to save this value to the user's settings store. We simply query the main window for it when it's needed.
Accessibility
In this commit, we also make a series of tweaks to help with usability/accessibility.
Menu items have been assigned keyboard accelerator keys (Windows only, as this isn't supported on Mac).
The Settings window is now modal and can be closed using the ESC (Escape) key.
The Settings window has been given a title.
Labels on the Settings page now appear in bold.
Help Menu
Last, but not least, under the new Help item in the Menu Bar (for discovery purposes, the Menu Bar is turned on by default for everyone initially), we add a number of items that make maintaining this application easier.
Changelist:
Remarks
Removal of Injected "Customize" Button Since many users have reported various scenarios in which the "Customize" button (that gets injected into Google Voice's markup on load) goes missing, we have stripped the button out entirely. It has been replaced by a new
Settings
item found in the main window's Menu Bar and notification area icon context menu.Zoom Shortcuts / Menu Bar In this change we do some work to support the standard keyboard shortcuts for zooming in and out that people are used to in the browser. That is, the ability to press
Ctrl+=
orCtrl++
to zoom in, to pressCtrl+-
orCtrl+-_
to zoom out, and to pressCtrl+0
to reset the zoom level. The key to implementing this was to add a Menu Bar to the main application window, placing inside it the standard role zoom items that come built in to Electron. Since a Menu Bar was necessary for zoom, I took it a step further and implemented menu items for all the primary functionality in the application. F11 is now supported as well, which allows you to go full screen.For those that don't want a Menu Bar, there is a new option in the Settings window for turning it off. But all zoom shortcuts will continue to work even when the Menu Bar is turned off, because rather than actually remove it, we just hide it :).
Zoom Slider In the Settings window, there's a new Slider control hooked up to the zoom functionality of the main window. Whereas we used to modify the zoom factor to zoom in/out, we now modify the zoom level, and we allow the exact same minimum and maximum values that the browser does (which is what Electron's built in zoom menu items allow). That is, we allow a zoom range of
25% to 500%
to be selected. Additionally, we take advantage of the fact that Electron remembers the last applied zoom level (the way the browser does), so we no longer need to save this value to the user's settings store. We simply query the main window for it when it's needed.Accessibility In this commit, we also make a series of tweaks to help with usability/accessibility.
Help Menu Last, but not least, under the new
Help
item in the Menu Bar (for discovery purposes, the Menu Bar is turned on by default for everyone initially), we add a number of items that make maintaining this application easier.