jerrrren / pe

0 stars 0 forks source link

Missing case where user closes window at if else in activity diagram. #9

Open jerrrren opened 1 year ago

jerrrren commented 1 year ago

DG considered the case when user clicks esc or cancel button but not if he cancels the window Screenshot (100).png

nus-se-script commented 1 year ago

Team's Response

The cancel button accounts for closing the window. When you close a window, you close it using the X checkbox. That can be inferred as a cancel button. Therefore, this is not a bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree that the X checkbox can be inferred as the cancel button as there are two distinct buttons in the window, one is the cancel button and one is the one for closing the window. The way I reason this is that suppose now you have a game application, and there are two buttons, one is the quit button and one is the exit window button. In this situation, you wouldn't say that this two buttons are the same thing right? Additionally in certain situations, the cancel button may have different behavior from the close window button, for instance in some applications, closing the window will still save the form fields without editing the database. Hence I think this two buttons should be treated distinctly. The form is a separate functionality from original ab3 so I think there is a need to go into this details, since you also included the behavior for the other buttons in the activity diagram.

However on second thoughts, in this situation I would also accept that the bug is of very-low severity instead of low since its not really much of an inconvenience in this situation.

Screenshot (103).png