search

jerry871002 / bsi-pt

BSI-PT algorithm in the paper "Opponent Exploitation Based on Bayesian Strategy Inference and Policy Tracking"
https://jerry871002.github.io/bsi-pt/
0 stars 0 forks source link

Check usage of functions and symbols in the paper #33

Closed jerry871002 closed 1 year ago

jerry871002 commented 1 year ago

Currently, in the latest code from Kueitso, some functions and symbols have unclear purposes. We need to check the paper and refine them (either removing them if they are not used or adding references to the paper in the comments).

Functions

Symbols

If the symbols are not defined in the paper, we can change the name to something more descriptive.

Related PR

After this issue is solved, we can keep moving forward on #14.

jerry871002 commented 1 year ago

From what I read from the paper, I am almost sure that ball_control_k1 and ball_control_k2 aren't in use anymore. Basically, the opponent actually does what it wants. So the generate_real_action function in env.py could be simplified a lot.

Also, the paper doesn't use the names mu1 and mu2. The paper simply lists the values (see Table 1, 8, 9, and 10). So we can choose whatever variable names that are more understandable for us.

The question about the symbols is mostly solved, but we need to double-check to verify. And the decypher of the mysterious functions goes on to you @YY87927 😁

jerry871002 commented 1 year ago

To our knowledge, infer_tau2 and run_uniformA do not have actual usage, so we remove them.