jerryc-nguyen commented 8 years ago

Hi @coderschoolreview , @avo1 I submitted assignment 2 and need your review. Many thanks.

thanhtan1105 commented 7 years ago

👍 Nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. This was a challenging assignment, congrats on completing it successfully!

Grading Summary:

Functionality: Good
Code Style: Outstanding
Visual Design: Good
Overall: Good

Detail node

Nice work specifying the Auto Layout constraints. But some point are also at faults

screenshot 2016-07-25 01 09 25

Nice for making expandable session in FilterVC, smooth, cool
That would be nice is if you handled the "no results" case gracefully, as well as didn't show empty gray lines when there is only 1 result.
The Cancel button in UISearchBar should be hidden when it don't have functionality.
If you have time, you can implement more function. Example MapView, custom UISwitch, detail page of restaurant

Great job dedicating enough time to do the homework. You learned a lot! Keep up the good work. 🍡

jerryc-nguyen commented 7 years ago

Many thanks for your review and suggestion. I will improve it later.

jerryc-nguyen / assignment_2_yelp

Assignment 2 review. #1

Grading Summary:

Detail node