search

jerryhcooke / smouldering_durtles

An attempt to keep a well-loved Android client for WaniKani alive amid changes
Other
61 stars 16 forks source link

SRS indicator positioning overlap #25

Open gijsvcuyck opened 1 year ago

gijsvcuyck commented 1 year ago

With the option "Enable SRS up/downgrade toast" enabled, a small popup appears after completing an item to show the new SRS level. I find this setting useful, but the popup slightly overlaps with the next question, making it harder to read. There is a large amount of empty space left on my screen which could be used somehow, instead of squishing everything together on the top. This is probably a phone/resolution specific issue so I don't know how easy or hard it is to fix something like this in general. Maybe something can be done with a setting to control padding? Or if the screen size can be read by the application, positioning could be based on that? Or maybe the needed padding is small enough that it can be added by default.

srs_screenshot.

I am using an OPPO Find X3 Lite, with smouldering durtles v1.0.5

gijsvcuyck commented 1 year ago

I forgot to mention, but this is not new to smouldering durtles. Flaming durtles had the same problem.

jerryhcooke commented 1 year ago

I don't particularly want to move the toast location as it's there, as far as I can tell, as it's the one of the positions that's mostly free regardless of the display size or orientation.

That said, I believe it could probably be handled a bit more elegantly and in line with the theme you're using. If I'm going to tweak it, I'd like to take the time to do it correctly and ideally I'd have it interact dynamically with the SRS indicator, by rolling that up or down depending on progress, or something similarly visually pleasing.

Leave it with me and I'll do my best to do something about it :)

shocklateboy92 commented 1 year ago

@gijsvcuyck you can workaround/fix this by adjusting the height of the main quiz question/text in settings. Settings -> Display Settings -> Fixed height of the main quiz question view I set mine to 240 and the toast no longer overlaps the text. I also increased the font size to make it look better.

@jerryhcooke maybe we should update the default values. I suspect they were decided back when phone screens were much smaller.

gijsvcuyck commented 1 year ago

@gijsvcuyck you can workaround/fix this by adjusting the height of the main quiz question/text in settings. Settings -> Display Settings -> Fixed height of the main quiz question view I set mine to 240 and the toast no longer overlaps the text. I also increased the font size to make it look better.

This indeed solves the problem. Thanks, I did not know this was an option in the settings. There is probably a better way to solve this than to get every user to individually tweak some constants with arcane names to fit their device, but at least it gives the option to fix it with some trial and error.