jerryhcooke / smouldering_durtles

An attempt to keep a well-loved Android client for WaniKani alive amid changes
Other
59 stars 16 forks source link

[Request] Toggle to invert/swap subject type/BG colors #37

Open machinaeZER0 opened 1 year ago

machinaeZER0 commented 1 year ago

Hello! Thanks again for helping to revive and maintain this app :) I had an idea for a feature request that (if possible) would be really neat to see implemented! At the moment I stick to the default Wanikani theme, in part because it matches the website, but also because I really like that the background of all of the "subject types" is themed with the color I choose. I really like the big pop of color, and it also helps me more quickly shift my brain into whatever category I am studying. [EDIT: I do also like that the character itself is rendered as white, as I think it generally pops well against the colored background]

I would be very interested in using some of the other themes, but I very much prefer my color scheme to affect the subject type background, rather than the radical/kanji/vocab itself. Would it be possible to either create a few dark themes where this is possible (while still darkening the BG of the app itself/using white text), or creating a toggle that would change whether the subject type colors affect the characters or the studied background?

machinaeZER0 commented 1 year ago

Example: Subject Type color for radicals is set to light blue

In Wanikani theme: white app background/white radical/light blue radical background In Nord theme: grey app BG/light blue radical/grey radical BG

Proposed change would make it so the Nord theme would show grey app BG/white radical/light blue BG - effectively "light mode" cards while keeping the majority of the app in dark mode.

jerryhcooke commented 1 year ago

It might not be too hard to put a toggle in that allows you to choose between the behaviour of it being background:base/item:type and background:type/item:base

I can take a look ☺️

shocklateboy92 commented 1 year ago

I think the better way to solve this is (instead of adding yet more options) is to fix the dark themes. Currently I also hate the way that vocabulary aren't purple and kanji aren't pink. I too found I accidentally give the kanji answer for vocab and vice versa waaaay more in dark theme than light.

I tried just taking the background colors of the light themes and setting them as the text colors of the dark theme. It worked, in that it was much easier to do reviews, but the colors were a bit jarring. I think with a bit of experimentation we could come up with colors that look pink/purple/blue, but are more suitable to a black background.

machinaeZER0 commented 1 year ago

That wouldn't really address my issue - I'd like a dark theme that continues to show my items in white, with an appropriately colored background (the way light mode does)

shocklateboy92 commented 1 year ago

Hmmm. That much I think you can already do using the theme customization options.

machinaeZER0 commented 1 year ago

Not that I am aware of. The wanikani theme is the only one where "subject type" is in white with a customizable background color: Screenshot_20231117-075932.png

And the other themes are inverted - hard-coded dark background colors for their subject types, where changing the color updates the character itself: Screenshot_20231117-080136.png

I would just like a dark theme whose subject type panels work the way our one light theme does (white on a color background). If it isn't possible or doesn't feel worth pursuing that's fine - just clarifying my position!