search

jerryhcooke / smouldering_durtles

An attempt to keep a well-loved Android client for WaniKani alive amid changes
Other
47 stars 14 forks source link

Add a theme that automatically switches according to system preferences #45

Closed shocklateboy92 closed 8 months ago

shocklateboy92 commented 8 months ago

Android now offers a system-wide dark theme, as well as the option to automatically toggle it based on sunset/sunrise.

This creates a new "AUTO" theme that chooses between LIGHT and BLACK_BREEZE based on whether the global system night mode is on.

Also makes this new theme the default, so that users will be exposed to the beautiful light theme we have as well.

jerryhcooke commented 8 months ago

Thank you for your work on this, it's a great idea.

However, before introducing into production, I'm going to expand a little on it and improve the theme selection options so that if the user opts to have an auto switching theme, they can select which theme they want to use for light mode and dark mode individually.

shocklateboy92 commented 8 months ago

I guess the simplest way you can implement that would be to remove the fake AUTO theme and add a second option called "Dark theme" or something with the description of "automatically switch to this theme when system dark mode is on".