search

jerryhcooke / smouldering_durtles

An attempt to keep a well-loved Android client for WaniKani alive amid changes
Other
55 stars 16 forks source link

Revert PreferencesFragment.java to last known good state #58

Closed shocklateboy92 closed 10 months ago

shocklateboy92 commented 10 months ago

@jerryhcooke the "corruption" caused by whatever tool you used seems to have introduced a bunch of other regressions. I think it's time to give up on "recovering" those code-changes and code up the theme change feature again from scratch :slightly_smiling_face:

jerryhcooke commented 10 months ago

@shocklateboy92 Can you be more specific about the regressions, because I'm a bit confused 😅

The version of the fragment that I merged back in wasn't a recovered version of the corrupted one, it was the fragment prior to the corruption, from backup. Are you noticing any issues occurring? I'm aware it's a bit quick and dirty, but the instant theme changing appears to be working as intended as far as my testing goes.

The setSummaryProvider bits are just to deal with returning a concatenated string for the preferences screen descriptions that includes the current theme.

The updateTheme function is what allows for the background colour (the only themed part of the preferences screen) to change instantly when a new theme is selected, which is something that I've been meaning to do for a while.

shocklateboy92 commented 10 months ago

Ah, I see. Then I guess it's just a normal regression. I described in a comment on your commit directly, but I guess I should file an actual issue.