search

jerryhcooke / smouldering_durtles

An attempt to keep a well-loved Android client for WaniKani alive amid changes
Other
59 stars 16 forks source link

Set keyboard language hint to X for Y options missing in latest version #60

Closed shocklateboy92 closed 10 months ago

shocklateboy92 commented 1 year ago

(These are the two options that I noticed - others may be missing too).

This is latest main. missing-options

And here's the same page when I revert commit 29cc00e: with-options

which is what led me to suspect it's to do with putting those unrelated code changes in the setVisibility() method. I'm unblocked locally with that fix, so I'm happy to close #58 and wait for you to investigate and fix @jerryhcooke :slightly_smiling_face:

jerryhcooke commented 1 year ago

Have resolved this, the error was indeed caused by improper nesting of my new bits inside the setVisibility() method, will merge my revision in once tested a bit more

shocklateboy92 commented 1 year ago

Awesome! Thanks for the fix. Have you pushed it somewhere? I didn't see any commits that touch the file.

PS: Sorry for assuming it's corrupted code and trying to revert the whole file 😅

hummusw commented 10 months ago

I'm able to see the language hint options in v1.1.0 now, are you still running into this issue on your end?

jerryhcooke commented 10 months ago

Believe this was related to the theme switching fix that 1.1.0 resolved, so closing, but let me know if you experience anything similar ☺️