search

jerryhcooke / smouldering_durtles

An attempt to keep a well-loved Android client for WaniKani alive amid changes
Other
47 stars 14 forks source link

Subject selection notice does not show up properly in advanced settings #65

Closed hummusw closed 5 months ago

hummusw commented 6 months ago

The text "If there are more candidates for your session than will fit, the settings below will let you influence how the subjects for the session are selected." does not show up correctly in the advanced settings menus. This info box is missing under Lesson advanced settings, Review advanced settings, and Self-study advanced settings.

Found in app version 1.0.9 Android version 10

Example of missing text box in Lesson advanced settings: Image of missing text box example

hummusw commented 6 months ago

Found another instance of missing text - the "The API token you supply here must have some write-permissions enabled. Without these, some functionality will not work..." text is missing if an invalid API key is provided:

image of missing text in API and audio downloads settings

It's possible that this bug affects all InfoPreferences in the settings menus?

hummusw commented 6 months ago

Sorry for the earlier close/reopen

I've opened pull request #66 which fixes the issue in my testing. Feel free to review the changes if you're available.

hummusw commented 5 months ago

Just installed v1.1.0 and looks like this isn't an issue anymore. Thanks for reviewing my pull request!