search

jerryhcooke / smouldering_durtles

An attempt to keep a well-loved Android client for WaniKani alive amid changes
Other
59 stars 16 forks source link

Better vacation mode handling #80

Open hummusw opened 10 months ago

hummusw commented 10 months ago

Currently when vacation mode is on the app will remove the button to start lessons and reviews on the home page. However, notifications are sent during vacation mode and the widget still displays the number of lessons and reviews that are "available."

It would be better to turn off notifications when vacation mode is detected. The widget should probably show some message indicating vacation mode as well.

I'm guessing this is low priority since most users are probably actively using WaniKani (not on vacation), but it would be good to address this sometime.

DropaBombOnEm commented 10 months ago

I also agree with this...

I hate getting notifications while in vacation mode!

jerryhcooke commented 6 months ago

This should be fairly easy to implement, having taken a look at the API reference there is a key for this in the user object. I'll need to look at whether I'm currently storing this value, but it should be a matter of simply only showing notifications if it's null.

{ "object": "user", "current_vacation_started_at": null, }