search

jerrykrinock / CategoriesObjC

General-purpose categories of Cocoa classes.
Other
274 stars 41 forks source link

Update NS(Attributed)String+Geometrics for ARC. #3

Closed marramgrass closed 11 years ago

marramgrass commented 11 years ago

I guess I'm assuming general availability of ARC for use. I'd imagine, though, where someone is starting a new project and adding in this code then they will be in an environment where ARC is fine.

The changes just involved remove a few calls to release.

Thanks for the code, by the way :)

jerrykrinock commented 11 years ago

Thank you, Mark. I wish Apple had provided a less brutal way of converting to ARC. The choices I have are (1) merge your pull request as is (2) ignore your pull request, (3) put the -release back in, surrounded by some kind of #if NO_ARC compiler directive.

I'm going to think about it for a few days and we'll see if anyone else has any comments.

jerrykrinock commented 11 years ago

OK, I decided on (3). I'm going to merge your pull request, but then add the compiler switches so it can still be used for non-ARC. I don't trust ARC enough to convert my large project to ARC. When I run 'leaks' on my project, I get zero leaks. When I run 'leaks' on any of Apple's apps, presumably built with ARC, I get leaks like crazy.