search

jerryscript-project / iotjs

Platform for Internet of Things with JavaScript http://www.iotjs.net
Other
2.58k stars 440 forks source link

Updated JerryScript submodule to 2.1. #1933

Closed kisbg closed 4 years ago

kisbg commented 4 years ago

IoT.js-DCO-1.0-Signed-off-by: bence gabor kis kisbg@inf.u-szeged.hu

LaszloLango commented 4 years ago

This patch breaks some features. What are the benefits of this PR? I think the broken features should be fixed before merge.

zherczeg commented 4 years ago

Strictly speaking it is not breaking any features, just checks rules which was not checked before and throws correct errors accordingly. In the future we need to think about supporting these use-cases, but that requires new features.

LaszloLango commented 4 years ago

Neither STM32 build nor NAPI reference won't work after this patch, so it is definitely breaking features.

DanielBallaSZTE commented 4 years ago

@kisbg There are still incorrect DFEATURE_... parameters in the cmake file still, and please also enable es2015-subset by default in build.py.

rtakacs commented 4 years ago

@kisbg Almost ok for me. Could you move the temorary-fix.txt into the config/nuttx/stm32f4dis/ folder and use .patch or .diff extension?