search

jerryscript-project / iotjs

Platform for Internet of Things with JavaScript http://www.iotjs.net
Other
2.59k stars 439 forks source link

build: Install static lib #1948

Closed rzr closed 3 years ago

rzr commented 4 years ago

This is useful for debian's iotjs-dev package

Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: https://github.com/jerryscript-project/iotjs/pull/rzr Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: https://github.com/jerryscript-project/iotjs/issues/1945 Bug-Debian: https://bugs.debian.org/957364 Update: 2020-07-24 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

rzr commented 3 years ago

review welcome

cc: @galpeter

rzr commented 3 years ago

This change is released in: https://tracker.debian.org/news/1184873/accepted-iotjs-10715-1-source-into-unstable/

rzr commented 3 years ago

Please review

meanwhile this change is in debian's testing branch:

https://tracker.debian.org/pkg/iotjs

[2020-10-26] iotjs 1.0+715-1 MIGRATED to testing (Debian testing watch)

cc: @akosthekiss, @dbatyai, @zherczeg

rzr commented 3 years ago

Thanks @akosthekiss ,

I will rebase https://github.com/jerryscript-project/iotjs/pull/1923 once https://github.com/jerryscript-project/iotjs/pull/1948 is merged

rzr commented 3 years ago

hi, can this be merged? FYI next debian release might feature this change

cc: @zherczeg @galpeter

rzr commented 3 years ago

Hi I plan to update iotjs in Debian, It would help to have this change in, then I'll make a snapshot release.

On https://github.com/jerryscript-project/iotjs/pull/1948#pullrequestreview-556337918 @akosthekiss said "LGTM"

I need 2 approvals to merge it, it's only a few lines to review:

https://github.com/jerryscript-project/iotjs/pull/1948/commits/b13fa73e12578ed1e2cb34018a360069a9ea8647

rzr commented 3 years ago

Thanks @zherczeg

Anyone for an other approval please ?

Cc: @LaszloLango , @ILyoan, @hs0225