search

jerrysu / gulp-rsync

Gulp plugin for deploying files via rsync
119 stars 51 forks source link

Resolve crashing due to 'setCursor' on stdout when piped #12

Closed nlundquist closed 8 years ago

nlundquist commented 9 years ago

Removing the line 'process.stdout.cursorTo(0);' prevents gulp-rsync from crashing when stdout is being piped to a file or an IDE. All tests past after this change.

jerrysu commented 9 years ago

Thanks for determining what the cause of the crash is. This line is needed when the output is not being piped to a file to get the output to appear properly.

Can you use the silent option?

nlundquist commented 9 years ago

I'm not going to use silent, I want to see this output in my IDE.

I also see the essentially the same output when using my gulp build outside of my IDE in a plain terminal environment. This line doesn't appear to be needed, unless it is supposed to resolve the occasional bug where a single line contains two output prefixes, like: "[20:38:03] gulp-rsync: [20:38:03] gulp-rsync: ".

agats commented 8 years ago

+1 for this fix. I also get it when trying use this plugin while running in Jenkins.