search

jerrysu / gulp-rsync

Gulp plugin for deploying files via rsync
119 stars 51 forks source link

return needed #44

Open carltonj2000 opened 7 years ago

carltonj2000 commented 7 years ago

Your first usage example has a return but the second one does not. That made all the difference for me. Without the return the rsync would not work. So maybe you can update your second usage example so that it has a return.

ebaskoro commented 7 years ago

G'day,

That's a good point. We will modify it ASAP. Cheers for that.

Eki

On 18 Nov 2016 5:25 AM, "Carlton Joseph" notifications@github.com wrote:

Your first usage example has a return but the second one does not. That made all the difference for me. Without the return the rsync would not work. So maybe you can update your second usage example so that it has a return.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jerrysu/gulp-rsync/issues/44, or mute the thread https://github.com/notifications/unsubscribe-auth/AAaTwRUB5MPkdZy-hW3Z-80WfR5vyUgMks5q_JwUgaJpZM4K1pLO .

c-johnson commented 6 years ago

Huge bump. Had no idea this return stated was needed in gulp.

c-johnson commented 6 years ago

Can anyone explain why this is? I get how not returning properly can mess up Gulp's default task ordering, but I don't understand why this wouldn't actually execute the rsync function.