Alerta matches fix - Githubissues

jertel / elastalert2

ElastAlert 2 is a continuation of the original yelp/elastalert project. Pull requests are appreciated!

https://elastalert2.readthedocs.org

Apache License 2.0

902 stars 284 forks source link

Alerta matches fix #1068

Closed dakotacody closed 1 year ago

dakotacody commented 1 year ago

Description

Checklist

[ x] I have reviewed the contributing guidelines.
[x ] I have included unit tests for my changes or additions.
[x ] I have successfully run make test-docker with my changes.
[x ] I have manually tested all relevant modes of the change in this PR.
[ ] I have updated the documentation.
[ x] I have updated the changelog.

Questions or Comments

jertel commented 1 year ago

Thanks for the submission. I'll leave this open for a few days to allow others to provide feedback. (Giving people a little extra time due to the holidays.)

jertel commented 1 year ago

You marked the checklist item for having updating the changelog but I don't see it in this PR. Did you not commit and push that change yet?

jertel commented 1 year ago

Relates to #1060.

dakotacody commented 1 year ago

Thanks @jertel I was on vacation last week and didn't see the updates!