jertel / elastalert2

ElastAlert 2 is a continuation of the original yelp/elastalert project. Pull requests are appreciated!
https://elastalert2.readthedocs.org
Apache License 2.0
931 stars 287 forks source link

handle slack error 429 #1119

Closed fberrez closed 1 year ago

fberrez commented 1 year ago

Description

This modifies the behavior when an error 429 - Too Many Requests occur when it sends a request to slack. It now prints a log instead of raising an error.

Before that, the log that occured the failure was pushed in a "pending" queue. This queue doesn't wait long enough to send another request to slack, resulting in another 429.

Checklist

nsano-rururu commented 1 year ago

Execution of test code is failing.

nsano-rururu commented 1 year ago

@fberrez Please correct the test code so that it does not cause an error.

JeffAshton commented 1 year ago

Doesn't this now result in the alert getting lost? Like how does Elastalert know how to retry later?

nsano-rururu commented 1 year ago

@jertel

I think this pull request with no response should be closed.