search

jertel / elastalert2

ElastAlert 2 is a continuation of the original yelp/elastalert project. Pull requests are appreciated!
https://elastalert2.readthedocs.org
Apache License 2.0
895 stars 282 forks source link

Issue not format email alert with HTML #1227

Closed thinhlx061996 closed 1 year ago

thinhlx061996 commented 1 year ago

Format_HTML_ElatAlert

jertel commented 1 year ago

Hello, thanks for your contribution. I think the HTML table format is useful, however this change cannot be accepted as-is, because it drops support for ASCII and markdown table types. That will be a breaking change to existing users that upgrade their installations.

If you refactor the change to continue supporting the existing formats and then add a new HTML table type, and meet the other contribution requirements then I see no reason we can't get this into the next release.

thinhlx061996 commented 1 year ago

Hello, thanks for your contribution. I think the HTML table format is useful, however this change cannot be accepted as-is, because it drops support for ASCII and markdown table types. That will be a breaking change to existing users that upgrade their installations.

If you refactor the change to continue supporting the existing formats and then add a new HTML table type, and meet the other contribution requirements then I see no reason we can't get this into the next release.

I appreciate this. Maybe it will be more appropriate when the new HTML table format is added and keep the structure of other types of table.

jertel commented 1 year ago

Closing in favor of #1260