jertel / elastalert2

ElastAlert 2 is a continuation of the original yelp/elastalert project. Pull requests are appreciated!
https://elastalert2.readthedocs.org
Apache License 2.0
922 stars 287 forks source link

add support for custom deployment annotations #1271

Closed victorpugin closed 1 year ago

victorpugin commented 1 year ago

Description

Hello, we are willing to use elastalert2 at my company with https://github.com/stakater/Reloader to manage our rules in a custom configmap, but the chart doesn't allow to add deployment annotations. I propose to add that option.

Checklist

Questions or Comments

jertel commented 1 year ago

Hello, thanks for the contribution. Please confirm that the chart deploys with, and without custom deployment annotations, without any errors, and then check the "I have manually tested all relevant modes of the change in this PR".

victorpugin commented 1 year ago

Hello, thanks for the contribution. Please confirm that the chart deploys with, and without custom deployment annotations, without any errors, and then check the "I have manually tested all relevant modes of the change in this PR".

Hello @jertel, I manually tested the chart with and without the custom deployment annotation successfully in production, it's working well.