jertel / elastalert2

ElastAlert 2 is a continuation of the original yelp/elastalert project. Pull requests are appreciated!
https://elastalert2.readthedocs.org
Apache License 2.0
895 stars 282 forks source link

Lark alerter support #1282

Closed seanyinx closed 11 months ago

seanyinx commented 11 months ago

Description

Checklist

Questions or Comments

nsano-rururu commented 11 months ago

Please add documentation about Lark alerter https://github.com/jertel/elastalert2/blob/master/docs/source/ruletypes.rst

nsano-rururu commented 11 months ago

Changes were made to python:3.11-slim in another pull request, so no changes are required in this pull request.

nsano-rururu commented 11 months ago

It seems that the description in schema.yaml is incorrect. Please modify as below.

  ### Lark
  lark_bot_id: {type: string}
  lark_msgtype: {type: string, enum: ['text']}
jertel commented 11 months ago

@seanyinx Do you think you'll have time to update the docs and make those minor changes @nsano-rururu suggested in the next few days? If so I'll be able to include this in the next release. It's not urgent so if you need more time we can leave this for the next in about 2 months. Thanks!

seanyinx commented 11 months ago

@seanyinx Do you think you'll have time to update the docs and make those minor changes @nsano-rururu suggested in the next few days? If so I'll be able to include this in the next release. It's not urgent so if you need more time we can leave this for the next in about 2 months. Thanks!

Sorry, I was on vacation last week. It's not urgent and I will make the changes as suggested today.

seanyinx commented 11 months ago

It seems that the description in schema.yaml is incorrect. Please modify as below.

  ### Lark
  lark_bot_id: {type: string}
  lark_msgtype: {type: string, enum: ['text']}

@nsano-rururu @jertel Docs on Lark alerter added and suggested changes made. Thanks.