search

jertel / elastalert2

ElastAlert 2 is a continuation of the original yelp/elastalert project. Pull requests are appreciated!
https://elastalert2.readthedocs.org
Apache License 2.0
859 stars 277 forks source link

Incorrect number of seconds in a day #1436

Closed Pikamander2 closed 2 months ago

Pikamander2 commented 2 months ago

Hi there, I used a code search and found an incorrect number of seconds in a day (84600 instead of 86400) listed in one of your files. I recommend fixing it to avoid incorrect timings that could potentially lead to unexpected behavior.

https://github.com/jertel/elastalert2/blob/3b4608ca8f9c4b69153ecd6a44a42d7a70562ecc/docs/source/alerts.rst#L250

jertel commented 2 months ago

Thanks for raising the problem. While I agree it is a typo, the file you referenced is a documentation file, not a code file.

I've pushed a fix for the documentation.

This is a community contributed project. In the future, it would be more helpful to submit a corrective pull request, rather than opening issues and asking someone else to fix it.