Always log if exception happens

jesbin / crawler4j

Automatically exported from code.google.com/p/crawler4j

0 stars 0 forks source link

Always log if exception happens #214

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What is the expected output? What do you see instead?
The current codebase contains lots of e. printStackTrace() or empty 
catch(Exception e)-blocks.
If one uses the crawler as an embedded library it's impossible to debug.

Please add proper logging statements even in empty catch blocks.

The clone https://code.google.com/r/acrocrawler-crawler4j/source/list partly 
added logger messages for error cases.

Original issue reported on code.google.com by acrocraw...@gmail.com on 17 Apr 2013 at 11:06

GoogleCodeExporter commented 8 years ago

Will be done

Original comment by avrah...@gmail.com on 11 Aug 2014 at 2:39

GoogleCodeExporter commented 8 years ago

Original comment by avrah...@gmail.com on 18 Aug 2014 at 3:37

Changed state: Accepted
Added labels: Priority-High, Type-Enhancement
Removed labels: Priority-Medium, Type-Defect

GoogleCodeExporter commented 8 years ago

Fixed in Revision: 457570261471

I have done some code refactoring as I changed the logging statements in the 
files

Original comment by avrah...@gmail.com on 22 Jan 2015 at 11:39

Changed state: Fixed