search

jescalan / accord

(unmaintained) a unified interface for compiled languages and templates in javascript
Other
137 stars 29 forks source link

Add support for less@3.0.0 #336

Closed stephenlacy closed 6 years ago

stephenlacy commented 6 years ago

I'll try to get a PR in shortly. No major api changes for the javascript interface that I know of - just the less backend options were changed.

stephenlacy commented 6 years ago

@jescalan Not sure how you like managing the yarn.lock file, I can commit it up or let you run yarn and lock the dependencies.

matthew-dean commented 6 years ago

No major api changes for the javascript interface that I know of

No, the main entry points for accord shouldn't change at all - that is, the render function didn't change.

matthew-dean commented 6 years ago

The reason for the major version change is that node names changed, so Less plugins with node visitors would be a breaking change. So the API did change somewhat, but for currently-undocumented node types.

stephenlacy commented 6 years ago

@jescalan any changes needed for this? cheers

jescalan commented 6 years ago

This was shipped a couple weeks ago 🎉