roots deploy -to heroku doesn't deploy production files

jescalan / roots

a toolkit for rapid advanced front-end development

http://roots.netlify.com/

Other

1.45k stars 133 forks source link

roots deploy -to heroku doesn't deploy production files #676

Open i8ramin opened 9 years ago

i8ramin commented 9 years ago

Running roots deploy -to heroku doesn't seem to run the production env compilation before deploying.

Manually running roots compile -e production and then ship public/ -to heroku works as expected. Tried latest master branch of roots cli as well.

Easy to reproduce.

roots clean
roots deploy -to {any target}
inspect contents of public folder .. not production files

benadamstyles commented 9 years ago

Pretty sure this is expected behaviour. The deploy command can't know what you have decided to call your production app.coffee file, I don't think it assumes it's called app.production.coffee. I could be wrong.

i8ramin commented 9 years ago

tried passing in a -e production to it as well, but no difference.

benadamstyles commented 9 years ago

Oh I see. I'll have a look at the roots source, maybe this can be fixed in a quick pr. You can always write an npm script like roots compile -e production && ship public/ -to heroku. However, you might need to use my fork of roots here (the kill-compile branch) which quits the compile process, which otherwise just hangs.

jescalan commented 9 years ago

This seems like a valid issue to me. At least you should be able to pass the environment flag to the deploy command. If someone could take a crack at a PR for this, would be incredible. If not I will get to this eventually, but I'm afraid it might be a while as I'm pretty strapped for time at the moment!