search

jescalan / roots

a toolkit for rapid advanced front-end development
http://roots.netlify.com/
Other
1.45k stars 133 forks source link

update all dependencies #680

Closed jescalan closed 8 years ago

jescalan commented 9 years ago

Some were in dire need of an update. Also get tests running on the latest version of node. Whoo!

jescalan commented 9 years ago

Ok so all the tests here are passing. This is good. The only thing that needs to be ironed out is whether the weird image clipping issue is occurring still.

dbox commented 9 years ago

You mean #655? I posted a test repo in there you can check against.

jescalan commented 9 years ago

Can confirm that the image issue is present. This really needs to be worked out in order for roots to move forward at all. I am going to start hacking on this with any free time I have.

dbox commented 9 years ago

And there was much rejoicing.

Thanks!! You're the best.

jescalan commented 9 years ago

Unfortunately I have very little free time, but I'll do my best!

jescalan commented 9 years ago

Just did a small test and this should fix #659 :tada:

dbox commented 9 years ago

:open_mouth: :open_mouth: :tada:

dbox commented 9 years ago

were you able to isolate something that was throwing roots segmentation fault ?

jescalan commented 9 years ago

yeah i had one project that would consistently throw it, after this upgrade it no longer is

jescalan commented 9 years ago

Ok, can confirm that the broken image issue is coming from the livereload system, specifically from infestor, ironically. If this is disabled, images work correctly. Will have a fix ready for this soon, then we can push out the release!

jescalan commented 8 years ago

Browsersync merge takes care of this :tada: