jesec / flood

A modern web UI for various torrent clients with a Node.js backend and React frontend.
https://flood.js.org
GNU General Public License v3.0
2.08k stars 127 forks source link

[bugfix] Fix tag trailing comma #715

Closed FinalDoom closed 6 months ago

FinalDoom commented 6 months ago

Filter empty tags when submitting a tag change via modal

Description

Empty tags are generally disallowed by input filtering, but a trailing comma is allowed in the tag input, which results in an empty tag. When submitted to the backend, this returns an error, and the modal hangs as loading.

This change will remove any empty tags, such as that generated by a trailing comma, prior to backend submission.

Types of changes

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (20a672a) 73.15% compared to head (16e15b0) 73.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #715 +/- ## ========================================== - Coverage 73.15% 73.14% -0.01% ========================================== Files 62 62 Lines 11375 11375 Branches 959 958 -1 ========================================== - Hits 8321 8320 -1 - Misses 3040 3041 +1 Partials 14 14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.