jeshuamaxey / ferret

A powerful tool for high information events. Collaborate with your community to filter the noise on Twitter and discover the most relevant, interesting and credible updates.
ferretapp.co.uk
MIT License
14 stars 3 forks source link

Replace twitterapi.json with config via environment variables? #23

Closed aendra-rininsland closed 10 years ago

aendra-rininsland commented 10 years ago

Related to the deployment discussion in #1, it really aids deployment and local development if things like API keys are stored in environment variables. You can then setup different env vars in different environments without having to change any of the code. It also means you don't store any credentials as plaintext, which is a nice security feature.

As well, this is the preferred way of doing things on both Elastic Beanstalk and Heroku.

giovannic commented 10 years ago

Great suggestion, this has been added in 6f61dbbe349115a9f9fba7c67929ea649b973268

aendra-rininsland commented 10 years ago

Awesome! Looks good! :shipit:

Closing issue; feel free to reopen if you're managing issues by closing them after the commit gets added to a release (and apols if so!).